Skip to content

Update attribute definition by named type methods and hide attribute.Description #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2020
Merged

Update attribute definition by named type methods and hide attribute.Description #2504

merged 4 commits into from
Jun 22, 2020

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jun 19, 2020 •
edited
Loading

@sneaxiy sneaxiy requested review from shendiaomo, typhoonzero and wangkuiyi and removed request for shendiaomo, typhoonzero and wangkuiyi June 19, 2020 15:34
@sneaxiy sneaxiy requested review from shendiaomo, typhoonzero and wangkuiyi and removed request for shendiaomo and typhoonzero June 20, 2020 03:06
@wangkuiyi wangkuiyi merged commit 6be86f2 into sql-machine-learning:develop Jun 22, 2020
@sneaxiy sneaxiy deleted the hiden_attr_description branch June 22, 2020 01:13
@sneaxiy sneaxiy mentioned this pull request Jun 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

@shendiaomo shendiaomo Awaiting requested review from shendiaomo

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sneaxiy @typhoonzero @wangkuiyi