Skip to content

Conversation

@brightcoder01
Copy link
Collaborator

@brightcoder01 brightcoder01 commented Jun 22, 2020

  • The data sources behind MaxCompute and Alisa are exactly the same - MaxCompute. The parser should be the same.
  • While we test the SQL statement with Alisa data source in Playground, we first choose ODPS parser, if not found (that's the current situation), we will use calcite parser instead.

Copy link
Collaborator

@lhw362950217 lhw362950217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brightcoder01 brightcoder01 merged commit ea036f5 into sql-machine-learning:develop Jun 22, 2020
@shendiaomo
Copy link
Collaborator

The change is not enough:

  1. The "maxcompute" key will map calcite parser.
  2. The "odps" parser cannot be release public.

@brightcoder01
Copy link
Collaborator Author

The change is not enough:

  1. The "maxcompute" key will map calcite parser.
  2. The "odps" parser cannot be release public.

The Maxcompute key will first find ODPS parser, if not found, will choose calcite parser.
Yes, ODPS parser won't be released publicly. We will use calcite parser if the data source is MaxCompute or Alisa.

@brightcoder01 brightcoder01 deleted the gml/alisa-parser branch June 22, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants