Minimize docker image #2526
Merged
Minimize docker image #2526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhw362950217
force-pushed
the
minimize_docker_image
branch
from
f7a9905 to
efdeeef
Compare
Yancey0623
reviewed
Jun 24, 2020
| /datasets/ | ||
|
|
||
| COPY docker/dev/find_fastest_resources.sh /usr/local/bin/ | ||
| RUN /bin/sh -c "source find_fastest_resources.sh && \ |
Collaborator
There was a problem hiding this comment.
Can we merge these two RUN command lines?
|
|
||
| sleep infinity | ||
|
|
||
| # c.f. https://stackoverflow.com/questions/2935183/bash-infinite-sleep-infinite-blocking for BusyBox |
Collaborator
There was a problem hiding this comment.
The voted answer is sleep infinity from the URL, can you please add more comment to explain why remove sleep infinity?
Collaborator
Author
There was a problem hiding this comment.
To minimize the image size, we did not install the bash, so we can't use sleep infinity here.
wangkuiyi
approved these changes
Jun 25, 2020
Collaborator
wangkuiyi
left a comment
wangkuiyi
left a comment
There was a problem hiding this comment.
Please feel free to merge this PR and file a new one to fix the comments.
| | cut -d '/' -f 2) | ||
| cur_speed=${cur_speed:-99999.9} | ||
| cur_speed=${cur_speed:-99999} | ||
| cur_speed=${cur_speed/.*/} |
Collaborator
There was a problem hiding this comment.
Need a comment here explaining this Bash syntax.
|
|
||
| COPY docker/mysql/install-mysql-server.bash / | ||
| RUN /install-mysql-server.bash | ||
| FROM alpine:3.12 |
Collaborator
There was a problem hiding this comment.
Need a comment here to note how much space does this change save.
This was referenced Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sql-machine-learning/playground#43
Try to use alpine base image and move init code to start.sh, image size optimized from 480M to 211M