Add model zoo to playground #2770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Jul 30, 2020
| value: 127.0.0.1:3306 | ||
| volumeMounts: | ||
| # bind to host's docker.sock to build image | ||
| - mountPath: /var/run/docker.sock |
Collaborator
There was a problem hiding this comment.
If the model zoo server runs in k8s, it will use kaniko to build image automatically.
Collaborator
Author
There was a problem hiding this comment.
This config is for single-user playground only. Using local docker is to avoid introducing new image dependency and keep the vm small.
And, thanks, I will use the kaniko way in our cloud playground.
typhoonzero
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2769