Skip to content

[Python] Avoid passing session configuration in data generator #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2019
Merged

[Python] Avoid passing session configuration in data generator #819

merged 2 commits into from
Sep 16, 2019

Conversation

@tonyyang-svail
Copy link
Collaborator

@tonyyang-svail tonyyang-svail commented Sep 12, 2019

Fix #818

Yancey0623
Yancey0623 approved these changes Sep 14, 2019
View reviewed changes
Copy link
Collaborator

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyyang-svail tonyyang-svail merged commit 88af2fe into sql-machine-learning:develop Sep 16, 2019
@tonyyang-svail tonyyang-svail deleted the fix_818 branch September 16, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yancey0623 Yancey0623 Yancey0623 approved these changes

@weiguoz weiguoz Awaiting requested review from weiguoz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python] Avoid session configuration in data generator

2 participants

@tonyyang-svail @Yancey0623