Skip to content

[Intermediate Representation] Add feature column type interface #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019
Merged

[Intermediate Representation] Add feature column type interface #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sql/codegen/feature_column.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ package codegen
type NumericColumn struct {
FieldMeta *FieldMeta
}

func (NumericColumn) isFeatureColumn() {}
4 changes: 3 additions & 1 deletion sql/codegen/intermediate_representation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ type FieldMeta struct {

// FeatureColumn indicates the feature column to be applied on the field. Please refer to
// github.com/sql-machine-learning/sqlflow/sql/codegen/feature_column.go for detailed list of all feature columns.
type FeatureColumn interface{}
type FeatureColumn interface {
isFeatureColumn()
}

// Attribute represents an parsed entry in the WITH clause.
type Attribute struct {
Expand Down