Support duckdb #22
Merged
Support duckdb #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyZhong
requested changes
Aug 26, 2025
sqlancer/Dockerfile
Outdated
|
|
||
| WORKDIR /root/sqlancer | ||
|
|
||
| ARG DUCKDB_JDBC_VERSION=1.3.0.0 |
Collaborator
There was a problem hiding this comment.
hmmm, is it hardcode or? I find it doesn't match the 1.2.2.0 in config
Collaborator
Author
There was a problem hiding this comment.
return to the original version
Collaborator
There was a problem hiding this comment.
I'm not sure if we should make the DuckDB components in the SQLancer Dockerfile. i.e., if we have more DBs, we might make this file very messy. Perhaps alternatively, we can have a 'fork' of the SQLancer Dockerfile in the duckdb folder?
Collaborator
Author
There was a problem hiding this comment.
add customized dockerfile to duckdb/
duckdb/config.json
Outdated
| "embedded": "yes", | ||
| "dbms": "duckdb", | ||
| "version": "1.2.2.0", | ||
| "username": "N/A", |
Collaborator
There was a problem hiding this comment.
Do we need this entry or we can also remove it with no hurt?
Collaborator
Author
There was a problem hiding this comment.
remove "version"
suyZhong
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support duckdb testing by using Versions Plugin to modify pom.xml while building sqlancer image.
Closes #18