Skip to content

log filename of unparsable mysql schema file #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

log filename of unparsable mysql schema file #246

merged 1 commit into from
Jan 10, 2020

Conversation

jmhodges
Copy link
Contributor

@jmhodges jmhodges commented Jan 9, 2020 •
edited
Loading

Updates #245

kevinburke1
kevinburke1 reviewed Jan 9, 2020
View reviewed changes
@kyleconroy
Copy link
Collaborator

Thanks @jmhodges! Once you update %s to `%w I'll merge this in.

@jmhodges jmhodges force-pushed the log_file_parser_err branch from 9e3ff8e to 9bc359a Compare January 10, 2020 06:36
@jmhodges
Copy link
Contributor Author

For reasons, I also fixed the other places that could use %w in #250

@jmhodges jmhodges force-pushed the log_file_parser_err branch from 9bc359a to 4701f5b Compare January 10, 2020 07:46
@kyleconroy kyleconroy merged commit 1766d19 into sqlc-dev:master Jan 10, 2020
@kyleconroy kyleconroy mentioned this pull request Jan 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy left review comments

+1 more reviewer

@kevinburke1 kevinburke1 kevinburke1 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmhodges @kyleconroy @kevinburke1