Skip to content

Conversation

@apatil
Copy link
Contributor

@apatil apatil commented Aug 27, 2023

This change does the following:

  • Surfaces the rowMode parameter in the bundlide SqliteClient and SqliteWorker.
  • Sets the default to 'object', which seems like the more common case. The first example in both sql.js' and the sqlite3 NPM packages' READMEs both fetch rows as objects.
  • Fixes a small issue in the README and adds a pointer to the "OO TypeScript types #1" API docs.

Copy link
Collaborator

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomayac tomayac merged commit 5d2b5ee into sqlite:main Aug 28, 2023
@sgbeal
Copy link
Collaborator

sgbeal commented Aug 28, 2023

Just for future reference regarding the links to the main docs: /doc/tip/... will always point to the most current version, no matter what branch it's on, whereas /doc/trunk/... will always point to the current trunk (which corresponds to the upstream trunk state). With only rare exceptions, /tip and /trunk are the same versions, but on rare occasion an upcoming-feature branch is used in that repo, and /tip would resolve to that branch.

@tomayac
Copy link
Collaborator

tomayac commented Aug 28, 2023

Are you saying that the README thus should be linking to /doc/trunk/ instead?

@sgbeal
Copy link
Collaborator

sgbeal commented Aug 28, 2023

It's not a "must," it just seemed worth pointing out. In that particular repository it's rare that branches are used, so there's no functional difference most of the time.

@tomayac
Copy link
Collaborator

tomayac commented Aug 28, 2023

Understood. Since this reflects trunk release cadence, let's link to that path then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants