Should we change ToUpper-ToLower methods as ToUpperInvariant-ToLowerInvariant methods

[kucuk-furkan]

Hello,

We start using SqlKata in out project. I faced an issue in development. My computer's language is English but culture is Turkish. In my machine if i use query.WhereStarts or query.WhereEnds it throws error that "The operator 'lıke' cannot be used. Please consider white listing it before using it". My machine culture is caused it. I can change my machine culture but in production i can't as all customers to change their culture. Although i need their cultures to show datetimes, decimals, floats as their culture settings. Because, you know, EVERY SINGLE COUNTRY uses different date formats (sorry but since the day that i met with datetime object, i'm little angry about this 😄)

If we use ToLowerInvariant(), ToUpperInvariant() in compiler, it wont depend machine culture. Should we change them to invariants?

querybuilder/QueryBuilder/Compilers/Compiler.cs

Line 743 in 5d64310

op = op.ToLower();

[hussamelvani]

Hey, When will the next minor realease happen?

[ahmad-moussawi]

@hussamelvani we have some conflicts that affected the release, but you can always get the pre-release version that include all theses updates.
check out https://www.myget.org/feed/sqlkata/package/nuget/SqlKata.Execution/1.1.8-CI-720 and https://sqlkata.com/docs#nightly-builds