fix ipv6 notation #1084
Merged
fix ipv6 notation #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovasoa
pushed a commit
that referenced
this pull request
Nov 7, 2025
On Mac OS, when localhost:8080 is defined and sqlpage config file, the SocketAddr is resolved with ipv6 address if ip V6 is available on the internal network.
```json
{
"listen_on": "localhost:8080"
}
```
On the terminal we can Ctrl + Click, but the URL is incorrect (ipV6 notation use bracket)
Actually we have
```shell
View your website at:
🔗 http://::1:8080
```
Instead of
```
View your website at:
🔗 http://[::1]:8080
```
Regards,
lovasoa
added a commit
that referenced
this pull request
Nov 7, 2025
* wip: perf guide * update guide * Add materialized views section to performance guide - Introduced a new section on materialized views, explaining their purpose and benefits for optimizing analytical queries. - Added an example SQL statement for creating a materialized view to compute total sales per store. - Provided guidance on refreshing materialized views manually or via external scripts. * Document nginx streaming and compression for sqlpage (#1080) * Docs: Add Nginx streaming and compression configuration Co-authored-by: contact <contact@ophir.dev> * Add NGINX streaming and compression configuration Co-authored-by: contact <contact@ophir.dev> * Refactor NGINX proxy settings documentation for clarity Co-authored-by: contact <contact@ophir.dev> * Refine NGINX proxy buffering recommendations for streaming Co-authored-by: contact <contact@ophir.dev> * Update NGINX proxy buffering settings for improved streaming performance Revised the documentation to clarify the impact of enabling and disabling proxy buffering in NGINX for SQLPage. Added concise recommendations for handling slow SQL queries and emphasized the importance of adjusting `compress_responses` in `sqlpage.json` when using a reverse proxy. Co-authored-by: contact <contact@ophir.dev> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> * Update dependencies and version for sqlpage to 0.39.1 - Bump versions of several dependencies including `aho-corasick`, `cc`, `clap`, `icu_collections`, and others to their latest releases. - Update `Cargo.toml` to reflect the new version of sqlpage. - Ensure compatibility with updated dependencies and improve overall project stability. * fix handling of one-element arrays in doc code generator see #1079 * In the table component, allow simple objects in custom_actions instead of requiring arrays of objects. fix #1079 * Implement faster icon loading by inlining icons from the Tabler sprite. The previous method required downloading and parsing a large file, causing delays in icon rendering. Now, icons are generated and cached, improving page load times. Update the icon helper to utilize the new inline method. * Update tabler icons to version 3.35 and refactor icon extraction logic for improved performance * icon image helper: logging and error handling - Changed debug logs to warning logs for invalid icon names and missing icons in the IconImgHelper. - Updated the way icons are retrieved from the ICON_MAP for better clarity and performance. * IconImgHelper: use raw string literals for SVG output * Refactor icon extraction logic in build.rs to improve performance and memory usage. The download_tabler_icons function now directly processes sprite content in memory, eliminating the need for temporary file storage. Updated extract_icons_from_sprite to handle byte slices instead of strings, enhancing efficiency. * build.rs: raise on missing icon id * Simlplify icon generation in build.rs * simplify icon _img helper * update input field docs fixes #1081 * better form documentation * fix ipv6 notation (#1084) On Mac OS, when localhost:8080 is defined and sqlpage config file, the SocketAddr is resolved with ipv6 address if ip V6 is available on the internal network. ```json { "listen_on": "localhost:8080" } ``` On the terminal we can Ctrl + Click, but the URL is incorrect (ipV6 notation use bracket) Actually we have ```shell View your website at: 🔗 http://::1:8080 ``` Instead of ``` View your website at: 🔗 http://[::1]:8080 ``` Regards, * Update dependencies in Cargo.lock to latest versions * Fix github pr ci cache warnings (#1086) * feat: Add shared-key to cargo cache action Co-authored-by: contact <contact@ophir.dev> * Refactor: Use matrix-specific cache key in CI Co-authored-by: contact <contact@ophir.dev> * feat: Cache Rust build artifacts only on main branch Co-authored-by: contact <contact@ophir.dev> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> * Enhance SQL performance guidance in migration script - Added detailed recommendations for using primary and foreign keys, including examples for product and sales tables. - Introduced best practices for indexing, query performance debugging, and database maintenance commands. - Included advice on lazy loading and reducing the number of queries to optimize SQLPage applications. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Christophe CHAUVET <christophe.chauvet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac OS, when localhost:8080 is defined and sqlpage config file, the SocketAddr is resolved with ipv6 address if ip V6 is available on the internal network.
{ "listen_on": "localhost:8080" }On the terminal we can Ctrl + Click, but the URL is incorrect (ipV6 notation use bracket)
Actually we have
Instead of
Regards,