WIP: Optimize run_sql by avoiding cloning immutable data #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- URL and POST parameters are now immutable after request initialization
- SET command creates user-defined variables in separate namespace
- Variable lookup: SET variables shadow request parameters
- Added sqlpage.variables('set') to inspect user-defined variables
- Simplified API: most functions now use &RequestInfo instead of &mut
- All tests passing (151 total)
- Warn when both URL and POST have same variable name - Warn when $var is used for POST-only variable (should use :var)
No need to branch on whether variables are provided since we clone in both cases anyway.
This reverts commit 60f5a05.
This is a draft refactoring to avoid cloning large immutable data (headers, cookies, body) when creating nested execution contexts in run_sql(). Changes: - RequestInfo now contains only immutable request data - ExecutionContext wraps Rc<RequestInfo> + mutable execution state - Avoids cloning potentially large strings in nested run_sql() calls Status: NOT COMPILING YET - this is work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS: DRAFT / WORK IN PROGRESS - Does not compile yet
This PR refactors the request handling to separate immutable request data from mutable execution state, avoiding unnecessary cloning of potentially large data structures.
Problem
Currently,
run_sql()clones the entireRequestInfowhich includes:This is wasteful since only
set_variablesandclone_depthneed to be cloned.Solution
Split into two structures:
RequestInfo: immutable request data (wrapped inRc)ExecutionContext: mutable execution state + reference to RequestInfoBenefits
run_sql()callsStatus
Based on: #1109