Pull request to add robots.txt and sitemap.xml files (v1) #643
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| User-agent: * | ||
| Disallow: /examples/authentication/login.sql # Block access to specific sensitive SQL files like this | ||
|
|
||
| Allow: / # Allow access to all public-facing SQL-generated pages | ||
|
|
||
| Sitemap: https://sql.datapage.app/sitemap.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> | ||
| <url> | ||
| <loc>https://sql.datapage.app/</loc> | ||
| <lastmod>2024-10-10</lastmod> | ||
| <priority>1.00</priority> | ||
| </url> | ||
| <url> | ||
| <loc>https://sql.datapage.app/component.sql</loc> | ||
| <lastmod>2024-10-10</lastmod> | ||
| <priority>0.80</priority> | ||
| </url> | ||
| <url> | ||
| <loc>https://sql.datapage.app/documentation.sql</loc> | ||
| <lastmod>2024-10-10</lastmod> | ||
| <priority>0.80</priority> | ||
| </url> | ||
| <url> | ||
| <loc>https://sql.datapage.app/your-first-sql-website/</loc> | ||
| <lastmod>2024-10-10</lastmod> | ||
| <priority>0.80</priority> | ||
| </url> | ||
|
Comment on lines
+19
to
+22
There was a problem hiding this comment. Is it ok to have such a little subset of the site in the sitemap ? Won't it penalize other pages ? We should probably either not have a sitemap, or have one that is generated dynamically in sql |
||
| <url> | ||
| <loc>https://beta.datapage.app/</loc> | ||
| <lastmod>2024-10-10</lastmod> | ||
| <priority>0.80</priority> | ||
| </url> | ||
| <url> | ||
| <loc>https://sql.datapage.app/performance.sql</loc> | ||
| <lastmod>2024-10-10</lastmod> | ||
| <priority>0.60</priority> | ||
| </url> | ||
| <url> | ||
| <loc>https://sql.datapage.app/blog.sql</loc> | ||
| <lastmod>2024-10-10</lastmod> | ||
| <priority>0.60</priority> | ||
| </url> | ||
| </urlset> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to hardcode the date like this ? Won't the prevent re-crawling when we update the page ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it remains hard coded for too long it is an issue, for this first try it is ok