Fix parsing error when conditional statement contains array access#433
Merged
alamb merged 1 commit intoapache:mainfrom Mar 12, 2022
Merged
Fix parsing error when conditional statement contains array access#433alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
…nditions contain arrays or map.
Pull Request Test Coverage Report for Build 1958518329
💛 - Coveralls |
alamb
approved these changes
Mar 12, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
LGTM -- thank you @monadbobo
| #[test] | ||
| fn parse_map_access_expr() { | ||
| let sql = r#"SELECT string_values[indexOf(string_names, 'endpoint')] FROM foos"#; | ||
| let sql = r#"SELECT string_values[indexOf(string_names, 'endpoint')] FROM foos WHERE id = 'test' AND string_value[indexOf(string_name, 'app')] <> 'foo'"#; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug that the access parsing is wrong when multiple query conditions contain arrays or map.