Skip to content

feat: Adding row click handlers to QueryResultPanel#130

Merged
ilyabo merged 4 commits intomainfrom
data-table-on-click
Sep 5, 2025
Merged

feat: Adding row click handlers to QueryResultPanel#130
ilyabo merged 4 commits intomainfrom
data-table-on-click

Conversation

@ilyabo
Copy link
Copy Markdown
Collaborator

@ilyabo ilyabo commented Sep 5, 2025 •
edited
Loading

  • QueryResultPanel: onClick and onRowDoubleClick propagated to DataTablePaginated
  • SqlEditor takes queryResultProps
  • SqlEditorSlice: configurable result limit options [100, 500, 1000] (queryResultLimit and queryResultLimitOptions can be passed to createSqlEditorSlice)

@ilyabo ilyabo requested a review from ibgreen September 5, 2025 16:11
ibgreen
ibgreen approved these changes Sep 5, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@ilyabo ilyabo merged commit 6ee36d3 into main Sep 5, 2025
4 checks passed
@ilyabo ilyabo deleted the data-table-on-click branch September 5, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilyabo @ibgreen