Backfilled http/2 data frame test and clarified comments.#472
Merged
codefromthecrypt merged 1 commit intosquare:masterfrom Jan 22, 2014
codefromthecrypt:backfill-data-test
Merged
Backfilled http/2 data frame test and clarified comments.#472codefromthecrypt merged 1 commit intosquare:masterfrom codefromthecrypt:backfill-data-test
codefromthecrypt merged 1 commit intosquare:masterfrom
codefromthecrypt:backfill-data-test
Conversation
Author
There was a problem hiding this comment.
scheduling progressive data send here seems to make most sense.
Collaborator
|
LGTM |
Author
|
PTAL I found that there's another part of the codebase that incidentally guards against hitting max frame length. |
Author
There was a problem hiding this comment.
There's already looping code here. Do we want to formalize that there's a max setting which will never fall below 16383, or replicate looping in the frame writers?
Collaborator
There was a problem hiding this comment.
Nope, no need to. (But we should recognize that we may change the looping above)
Collaborator
|
LGTM |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jan 22, 2014
Backfilled http/2 data frame test and clarified comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.