Skip to content

Conversation

n8chur
Copy link
Collaborator

@n8chur n8chur commented Dec 8, 2021

Overview

  • Adds additional view controller property forwarding to contained view controllers in ContainerViewController and DescribedViewController
  • Fixes a missing preferred content size update and avoids updating the preferred content size in a few cases where it did not previously
  • Adds contained child view controllers as children in the initializer for these containers. This allows consumers to inspect properties of the view controller before the view has loaded and get appropriate values—previously this would return a default value until the view was loaded even though the information was available.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2021

CLA assistant check
All committers have signed the CLA.

@n8chur
Copy link
Collaborator Author

n8chur commented Dec 8, 2021

  • Move view controller containment (addChild etc.) to initializers

@n8chur n8chur closed this Dec 9, 2021
@n8chur n8chur reopened this Dec 9, 2021
@n8chur n8chur closed this Dec 10, 2021
@n8chur n8chur reopened this Dec 10, 2021
@n8chur n8chur marked this pull request as ready for review December 10, 2021 20:49
@n8chur
Copy link
Collaborator Author

n8chur commented Dec 10, 2021

This containment / preferredContentSize pattern has been used in Market and has proven to work well for us so far!

@n8chur n8chur merged commit 5f28db5 into square:main Dec 10, 2021
@n8chur n8chur deleted the westin/fix-vc-containment branch December 10, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants