Update Mermaid to 11.* #7475
Merged
Update Mermaid to 11.* #7475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manselmi
commented
Aug 23, 2024
| /* Flowchart edge label */ | ||
| .edgeLabel, | ||
| .edgeLabel rect { | ||
| .edgeLabel p { |
Contributor
Author
There was a problem hiding this comment.
I made this change in order for the edge labels in this flowchart to have their background look the same as the diagram backgroud (in both dark and light modes). I know little about CSS and HTML - I'm not sure if this change breaks anything outside of my limited testing.
Owner
There was a problem hiding this comment.
Yes, I think we might need this change, or edge labels are not readable in dark mode. It looks like they changed the rect to p, so this change should be okay. We'll find out as we go whether we need more changes.
Owner
|
Thanks for the PR! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the major version of Mermaid from 10 to 11.
Supported diagram types (flowcharts, sequence diagrams, state diagrams, class diagrams and entity-relationship diagrams) all seem to render the same as the ones here, in both dark and light modes.