This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Added Object interface for Commit, Tree, Blob and Tag #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JoshuaSjoding
commented
Mar 3, 2016
JoshuaSjoding
commented
- New Object interface is distinct from core.Object
- New Object interface is used in places where returned object could be of any type
- Object is implemented by Commit, Tree, Blob, File and Tag
- Added Repository.Object function for retrieving objects of any type
- Tag.Object now returns Object instead of core.Object
- Tag target hash is now publicly accessible
- Renamed Tag.Type field to Tag.TargetType, making it distinct from Tag.Type function
- Fixed infinite recursive loop in TagIter.Close
- TreeWalker.Next now returns Object instead of core.Object
- Removed some duplicate test setup code
Current coverage is
|
| // This interface is intentionally different from core.Object, which is a lower | ||
| // level interface used by storage implementations to read and write objects. | ||
| type Object interface { | ||
| ID() core.Hash |
Contributor
Author
There was a problem hiding this comment.
I really wanted to call this function Hash() so that the name matched core.Object's equivalent, but that would have conflicted with the existing Hash field on Commit, Tree, Blob and Tag.
* New Object interface is distinct from core.Object * New Object interface is used in places where returned object could be of any type * Object is implemented by Commit, Tree, Blob, File and Tag * Added Repository.Object function for retrieving objects of any type * Tag.Object now returns Object instead of core.Object * Tag target hash is now publicly accessible * Renamed Tag.Type field to Tag.TargetType, making it distinct from Tag.Type function * Fixed infinite recursive loop in TagIter.Close * TreeWalker.Next now returns Object instead of core.Object * Removed some duplicate test setup code
JoshuaSjoding
force-pushed
the
git-object-interface
branch
from
3ff0a7e to
619e512
Compare
mcuadros
added a commit
that referenced
this pull request
Mar 8, 2016
Added Object interface for Commit, Tree, Blob and Tag
mcuadros
added a commit
that referenced
this pull request
Jan 31, 2017
Added Object interface for Commit, Tree, Blob and Tag
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Protect file removing with upload token
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.