This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Fix PullDefault to not cause panics. #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TripleDogDare
force-pushed
the
fix-repository-pulldefault
branch
2 times, most recently
from
182cccb to
00710e4
Compare
The `remote.upInfo` is not set until `Connect()` is called. However, `repository.PullDefault()` requires that it exists when it calls `remote.DefaultBranch()`. This can be solved by pushing the default branch discovery into `repository.Pull()`. The empty string "" is not a valid branch name, so by allowing the empty string to mean 'default branch' in the `Pull()` function we can allow `PullDefault()` to not need a `remote.Connect()` call before calling `repository.Pull()`
TripleDogDare
force-pushed
the
fix-repository-pulldefault
branch
from
00710e4 to
213eb79
Compare
mcuadros
added a commit
that referenced
this pull request
Jan 31, 2017
Fix PullDefault to not cause panics.
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Add test for Streaming mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
remote.upInfois not set untilConnect()is called.However,
repository.PullDefault()requires that it exists whenit calls
remote.DefaultBranch(). This can be solved by pushingthe default branch discovery into
repository.Pull().The empty string "" is not a valid branch name, so by allowing
the empty string to mean 'default branch' in the
Pull()functionwe can allow
PullDefault()to not need aremote.Connect()callbefore calling
repository.Pull()Relates to issue #45