refactor: instantiate struct definition first

[ssssota]

Summary by CodeRabbit

• Refactor
  • Optimized internal handling of image metadata and processed image reads by reusing typed wrappers, reducing repetitive object creation.
  • Centralized logic for improved reliability and easier maintenance, with unchanged behavior and public interfaces.
  • Existing workflows continue to work as before; error handling remains the same.
  • May yield minor performance improvements in repeated operations due to reduced allocations.

[coderabbitai]

Walkthrough

Refactors LibRawWasm interactions to use pre-defined typed struct wrappers. Functions now delegate to wrapper.read with buffer/offset, removing per-call inline constructions and overrides. Object creation is centralized as constants. Control flow and error handling remain unchanged. No changes to exported/public declarations.

Changes

Cohort / File(s)	Summary
LibRawWasm wrappers refactor packages/libraw.wasm/src/index.ts	Replaced inline struct wrapper creation with pre-defined typed wrappers (imgother_t, iparams_t, makernotes_lens_t, lensinfo_t, processed_image_t, shootinginfo_t, makernotes_t, thumbnail_t). Updated readProcessedImage, getIParams, getLensInfo, getImgOther, getThumbnail, getShootingInfo, getMakernotes to call .read(...). Centralized/cached wrapper instances; preserved behavior and error handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through structs with tidy cheer,
Pre-wrapped fields now waiting here.
No more twigs of ad-hoc build—
One burrow, neatly, logic stilled.
Buffers whisper, offsets align;
Carrots cached—performance fine.
Thump! Refactor done in time.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The provided title is too vague and generic to convey the essence of the refactor, as it does not clearly state that the change centralizes and reuses predefined typed wrappers for LibRaw structures rather than inline definitions. Because it fails to specify what structs or wrappers are involved and what benefit is achieved, it is difficult for reviewers to grasp the main change at a glance.	Please choose a more descriptive title that highlights the core refactoring of using predefined typed wrappers for LibRaw structures, for example: “refactor: centralize LibRaw struct wrappers for reuse” or “refactor: predefine and reuse typed LibRaw structure wrappers.”

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch instantiate-struct-definition

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12494fc and fff0fa2.

📒 Files selected for processing (1)

• packages/libraw.wasm/src/index.ts (4 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

packages/libraw.wasm/src/index.ts (1)

packages/libraw.wasm/src/libraw-types.ts (8)

• libraw_imgother_t (285-298)
• libraw_iparams_t (307-326)
• libraw_makernotes_lens_t (364-400)
• libraw_lensinfo_t (348-363)
• libraw_processed_image_t (631-640)
• libraw_shootinginfo_t (713-724)
• libraw_makernotes_t (401-416)
• libraw_thumbnail_t (800-808)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: check

🔇 Additional comments (8)

packages/libraw.wasm/src/index.ts (8)

28-76: LGTM! Clean refactor to centralize struct definitions.

The pre-defined struct wrappers correctly mirror the base struct definitions with appropriate overrides for string conversions, enums, and variable-length fields. The centralization eliminates repetitive inline construction and improves maintainability.

---

176-179: LGTM! Simplified by delegating to pre-defined wrapper.

The refactor correctly uses the centralized processed_image_t definition, making the code cleaner while preserving functionality.

---

272-275: LGTM! Consistent refactor pattern.

Correctly delegates to the centralized iparams_t definition.

---

278-281: LGTM! Consistent refactor pattern.

Correctly delegates to the centralized lensinfo_t definition.

---

284-287: LGTM! Consistent refactor pattern.

Correctly delegates to the centralized imgother_t definition.

---

310-313: LGTM! Consistent refactor pattern.

Correctly delegates to the centralized thumbnail_t definition.

---

316-319: LGTM! Consistent refactor pattern.

Correctly delegates to the centralized shootinginfo_t definition.

---

322-325: LGTM! Consistent refactor pattern.

Correctly delegates to the centralized makernotes_t definition, completing the consistent refactor across all getter methods.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}