Placeholder-Validation errors on multi-line query

[staabm]

running a query like

$queryString = '

            SELECT
                land.*,
                COALESCE(NULLIF(landsprache.ort, ""), land.ort) AS ort
            FROM land
                INNER JOIN landsprache ON (land.landid=landsprache.landid and landsprache.spracheid = ?)
            WHERE (webinaktiv = 0) ORDER BY COALESCE(NULLIF(landsprache.ort, ""), land.ort) ASC
';

thru

phpstan-dba/src/QueryReflection/QueryReflection.php

Lines 349 to 358 in 3996639

	if (preg_match_all(self::REGEX_UNNAMED_PLACEHOLDER, $queryString, $matches) > 0) {
	$candidates = $matches[0];
	// filter placeholders within quoted strings
	$candidates = array_filter($candidates, function ($candidate) {
	return '"' !== $candidate[0] && "'" !== $candidate[0];
	});
	return \count($candidates);
	}

does not return 1 as the number of matched placeholders

[staabm]

put into a short snippet, the problems repros with

<?php

$queryString = '
            SELECT
                land.*,
                COALESCE(NULLIF(landsprache.ort, ""), land.ort) AS ort
            FROM land
                INNER JOIN landsprache ON (land.landid=landsprache.landid and landsprache.spracheid = ?)
            WHERE (webinaktiv = 0) ORDER BY COALESCE(NULLIF(landsprache.ort, ""), land.ort) ASC
';


var_dump(preg_match_all('{(["\'])([^"\']+\1)|(\?)}', $queryString, $matches));

     $candidates = $matches[0]; 
  
     // filter placeholders within quoted strings 
     $candidates = array_filter($candidates, function ($candidate) { 
         return '"' !== $candidate[0] && "'" !== $candidate[0]; 
     }); 
  
var_dump (\count($candidates));   // should return 1

@Seldaek since you are kind of a regex guru.. could you give me a hint what is wrong in this regex?

[Seldaek]

I think the problem is [^"\']+ should be [^"\']* to allow empty strings, e.g. preg_match_all('{(["\'])([^"\']*\1)|(\?)}', $queryString, $matches)

[staabm]

@Seldaek thx for the tip. works like a charm