Prototype support for bindValue/bindParam on PDOStatement

[xPaw]

I think this adds the right pieces.

refs #199

[staabm]

This looks great.

we need more testcoverage, especially in

• https://github.com/xPaw/phpstan-dba/blob/pdo-bind-param/tests/default/data/unresolvable-pdo-statement.php
• https://github.com/xPaw/phpstan-dba/blob/pdo-bind-param/tests/default/data/pdo-stmt-execute-error.php

for the error cases.

expected error messages need to be put into

• https://github.com/xPaw/phpstan-dba/blob/pdo-bind-param/tests/default/PdoStatementExecuteMethodRuleTest.php
• https://github.com/xPaw/phpstan-dba/blob/pdo-bind-param/tests/default/UnresolvablePdoStatementRuleTest.php

[xPaw]

While adding tests, it seems like it's finding bind calls from previous pdo statements, so the code isn't entirely correct. It needs to stop once it hits prepare or something.

[staabm]

For inspiration, a few real world examples can be taken from
https://github.com/shopware/shopware/search?q=bindParam

[xPaw]

I think I fixed it. I manually constructed ConstantArrayType out of the collected bind calls.

[staabm]

do we need this check here, or could we just feed everything into $parameterKeys and resolveParameters later on would decide which types are supported and which not?

[xPaw]

It's constrained by the constructor, so phpstan complained.

[staabm]

i love it

[staabm]

I think we can/should cover a case where some params are bound via bindValue or bindParam and others are given to execute at the same time.. I guess this is supported in pdo?

[xPaw]

I looked at the pdo code, and it seemed like if you pass into execute, it empties any of the previously bound variables. I may have misunderstood though.

[staabm]

would be cool if you could run a small example on your own and verify the thesis.

if its right, we might even create a PHPStan-Rule which errors on bindValue/.. calls, when parameters are passed to execute

[xPaw]

Yeah it's the case:

	$st = Container::Database()->prepare( 'SELECT * FROM Apps WHERE AppID = :a OR AppID = :b' );
	$st->bindValue( ':a', 123 );
	$st->execute( [ ':b' => 456 ] ); // SQLSTATE[HY093]: Invalid parameter number

[staabm]

Cool, thx

#275