Skip to content

Remove recording workaround #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Remove recording workaround #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e6c8c3
Remove recording workaround
staabm Feb 9, 2022
7590e04
regenerate caches
clxmstaab Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/QueryReflection/RecordingQueryReflector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ public function validateQueryString(string $queryString): ?Error

public function getResultType(string $queryString, int $fetchType): ?Type
{
// built the query string cache, also on result-type checking, to make sure the cachefile contains all required information.
// result-type checking is triggered by phpstan analysis via our phpstan-extensions, while the query-validation isn't.
$this->validateQueryString($queryString);

$resultType = $this->reflector->getResultType($queryString, $fetchType);

$this->reflectionCache->putResultType(
Expand Down
Loading