Skip to content

Skip Rule* tests when not using MysqliReflector #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Skip Rule* tests when not using MysqliReflector #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a00f59
Skip Rule* tests when not using MysqliReflector
clxmstaab Feb 12, 2022
ae49066
more explicit test names
clxmstaab Feb 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/ReflectorFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ final class ReflectorFactory
{
public static function create(string $cacheFile): QueryReflector
{
// handle defaults
if (false !== getenv('GITHUB_ACTION')) {
$host = getenv('DBA_HOST') ?: '127.0.0.1';
$user = getenv('DBA_USER') ?: 'root';
Expand All @@ -27,6 +28,10 @@ public static function create(string $cacheFile): QueryReflector

$mode = getenv('DBA_MODE') ?: 'recording';
$reflector = getenv('DBA_REFLECTOR') ?: 'mysqli';

// make env vars available to tests, in case non are defined yet
putenv('DBA_REFLECTOR='.$reflector);

if ('recording' === $mode) {
if ('mysqli' === $reflector) {
$mysqli = @new mysqli($host, $user, $password, $dbname);
Expand Down
6 changes: 5 additions & 1 deletion ...les/PdoStatementExecuteMethodRuleTest.php → ...tExecuteMethodRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<PdoStatementExecuteMethodRule>
*/
class PdoStatementExecuteMethodRuleTest extends AbstractServiceAwareRuleTestCase
class PdoStatementExecuteMethodRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function getRule(): Rule
{
Expand All @@ -18,6 +18,10 @@ protected function getRule(): Rule

public function testParameterErrors(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/pdo-stmt-execute-error.php';

$this->analyse([__DIR__.'/data/pdo-stmt-execute-error.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...rrorInPreparedStatementMethodRuleTest.php → ...tatementMethodRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInPreparedStatementMethodRule>
*/
class SyntaxErrorInPreparedStatementMethodRuleTest extends AbstractServiceAwareRuleTestCase
class SyntaxErrorInPreparedStatementMethodRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function getRule(): Rule
{
Expand All @@ -18,6 +18,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/syntax-error-in-prepared-statement.php';

$this->analyse([__DIR__.'/data/syntax-error-in-prepared-statement.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...aredStatementMethodSubclassedRuleTest.php → ...thodSubclassedRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInPreparedStatementMethodRule>
*/
class SyntaxErrorInPreparedStatementMethodSubclassedRuleTest extends AbstractServiceAwareRuleTestCase
class SyntaxErrorInPreparedStatementMethodSubclassedRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function getRule(): Rule
{
Expand All @@ -18,6 +18,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/syntax-error-in-method-subclassed.php';

$this->analyse([__DIR__.'/data/syntax-error-in-method-subclassed.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...es/SyntaxErrorInQueryFunctionRuleTest.php → ...nQueryFunctionRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryFunctionRule>
*/
class SyntaxErrorInQueryFunctionRuleTest extends AbstractServiceAwareRuleTestCase
class SyntaxErrorInQueryFunctionRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function getRule(): Rule
{
Expand All @@ -18,6 +18,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/syntax-error-in-query-function.php';

$this->analyse([__DIR__.'/data/syntax-error-in-query-function.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...ules/SyntaxErrorInQueryMethodRuleTest.php → ...rInQueryMethodRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryMethodRule>
*/
class SyntaxErrorInQueryMethodRuleTest extends AbstractServiceAwareRuleTestCase
class SyntaxErrorInQueryMethodRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function getRule(): Rule
{
Expand All @@ -18,6 +18,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/syntax-error-in-query-method.php';

$this->analyse([__DIR__.'/data/syntax-error-in-query-method.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...xErrorInQueryMethodSubclassedRuleTest.php → ...thodSubclassedRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryMethodRule>
*/
class SyntaxErrorInQueryMethodSubclassedRuleTest extends AbstractServiceAwareRuleTestCase
class SyntaxErrorInQueryMethodSubclassedRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function getRule(): Rule
{
Expand All @@ -18,6 +18,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/syntax-error-in-method-subclassed.php';

$this->analyse([__DIR__.'/data/syntax-error-in-method-subclassed.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...ules/UnresolvablePdoStatementRuleTest.php → ...lePdoStatementRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<PdoStatementExecuteMethodRule>
*/
class UnresolvablePdoStatementRuleTest extends AbstractServiceAwareRuleTestCase
class UnresolvablePdoStatementRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function setUp(): void
{
Expand All @@ -30,6 +30,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/unresolvable-pdo-statement.php';

$this->analyse([__DIR__.'/data/unresolvable-pdo-statement.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...UnresolvablePreparedStatementRuleTest.php → ...paredStatementRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInPreparedStatementMethodRule>
*/
class UnresolvablePreparedStatementRuleTest extends AbstractServiceAwareRuleTestCase
class UnresolvablePreparedStatementRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function setUp(): void
{
Expand All @@ -30,6 +30,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/unresolvable-statement.php';

$this->analyse([__DIR__.'/data/unresolvable-statement.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...les/UnresolvableQueryFunctionRuleTest.php → ...eQueryFunctionRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryFunctionRule>
*/
class UnresolvableQueryFunctionRuleTest extends AbstractServiceAwareRuleTestCase
class UnresolvableQueryFunctionRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function setUp(): void
{
Expand All @@ -30,6 +30,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/unresolvable-query-in-function.php';

$this->analyse([__DIR__.'/data/unresolvable-query-in-function.php'], [
Expand Down
6 changes: 5 additions & 1 deletion ...rules/UnresolvableQueryMethodRuleTest.php → ...bleQueryMethodRuleMysqliReflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* @extends AbstractServiceAwareRuleTestCase<SyntaxErrorInQueryMethodRule>
*/
class UnresolvableQueryMethodRuleTest extends AbstractServiceAwareRuleTestCase
class UnresolvableQueryMethodRuleMysqliReflectorTest extends AbstractServiceAwareRuleTestCase
{
protected function setUp(): void
{
Expand All @@ -30,6 +30,10 @@ protected function getRule(): Rule

public function testSyntaxErrorInQueryRule(): void
{
if ('mysqli' !== getenv('DBA_REFLECTOR')) {
$this->markTestSkipped('Only works with MysqliReflector');
}

require_once __DIR__.'/data/unresolvable-query-in-method.php';

$this->analyse([__DIR__.'/data/unresolvable-query-in-method.php'], [
Expand Down