Use lowercase table name in tests to fix issue on Windows #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
changed the title
staabm
approved these changes
Feb 19, 2022
Owner
staabm
left a comment
staabm
left a comment
There was a problem hiding this comment.
The fix/workaround seems fine for our testsuite.
I think we will see when phpstan-dba is used in various setups, whether we need a actual fix for the underlying problem.
After re-recording the replay information this can be merged.
Thank you
Contributor
Author
|
I think this might only be a problem for error messages where the table name is printed? Because quering tables in different casing when table exists works fine. |
Owner
thats one case, correct. I did not think it through whether there are other cases which are relevant. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #273