Skip to content

cover quoted query strings with tests #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2022
Merged

cover quoted query strings with tests #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2d8e5c
cover quoted query strings with tests
clxmstaab Jan 4, 2022
e0df602
cs
clxmstaab Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions .phpstan-dba.cache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,75 @@
)),
),
),
'SELECT email, adaid FROM ada WHERE adaid=1' =>
array (
'error' => NULL,
'result' =>
array (
1 =>
PHPStan\Type\Constant\ConstantArrayType::__set_state(array(
'keyType' =>
PHPStan\Type\UnionType::__set_state(array(
'types' =>
array (
0 =>
PHPStan\Type\Constant\ConstantStringType::__set_state(array(
'value' => 'adaid',
'isClassString' => false,
)),
1 =>
PHPStan\Type\Constant\ConstantStringType::__set_state(array(
'value' => 'email',
'isClassString' => false,
)),
),
)),
'itemType' =>
PHPStan\Type\UnionType::__set_state(array(
'types' =>
array (
0 =>
PHPStan\Type\IntegerRangeType::__set_state(array(
'min' => 0,
'max' => 4294967295,
)),
1 =>
PHPStan\Type\StringType::__set_state(array(
)),
),
)),
'keyTypes' =>
array (
0 =>
PHPStan\Type\Constant\ConstantStringType::__set_state(array(
'value' => 'email',
'isClassString' => false,
)),
1 =>
PHPStan\Type\Constant\ConstantStringType::__set_state(array(
'value' => 'adaid',
'isClassString' => false,
)),
),
'valueTypes' =>
array (
0 =>
PHPStan\Type\StringType::__set_state(array(
)),
1 =>
PHPStan\Type\IntegerRangeType::__set_state(array(
'min' => 0,
'max' => 4294967295,
)),
),
'nextAutoIndex' => 0,
'optionalKeys' =>
array (
),
'allArrays' => NULL,
)),
),
),
'SELECT email, adaid, gesperrt, freigabe1u1 FROM ada' =>
array (
'error' => NULL,
Expand Down
27 changes: 27 additions & 0 deletions tests/data/mysqli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,31 @@ public function escape(mysqli $mysqli, int $i, float $f, $n, string $s, $nonE, s
assertType('non-empty-string', $mysqli->real_escape_string($nonE));
assertType('string', $mysqli->real_escape_string($s));
}

/**
* @param numeric $n
* @param non-empty-string $nonE
* @param numeric-string $numericString
*/
public function quotedArguments(mysqli $mysqli, int $i, float $f, $n, string $s, $nonE, string $numericString)
{
$result = $mysqli->query('SELECT email, adaid FROM ada WHERE adaid='.$mysqli->real_escape_string((string) $i));
assertType('mysqli_result<array{email: string, adaid: int<0, 4294967295>}>|false', $result);

$result = $mysqli->query('SELECT email, adaid FROM ada WHERE adaid='.$mysqli->real_escape_string((string) $f));
assertType('mysqli_result<array{email: string, adaid: int<0, 4294967295>}>|false', $result);

$result = $mysqli->query('SELECT email, adaid FROM ada WHERE adaid='.$mysqli->real_escape_string((string) $n));
assertType('mysqli_result<array{email: string, adaid: int<0, 4294967295>}>|false', $result);

$result = $mysqli->query('SELECT email, adaid FROM ada WHERE adaid='.$mysqli->real_escape_string($numericString));
assertType('mysqli_result<array{email: string, adaid: int<0, 4294967295>}>|false', $result);

// when quote() cannot return a numeric-string, we can't infer the precise result-type
$result = $mysqli->query('SELECT email, adaid FROM ada WHERE adaid='.$mysqli->real_escape_string($s));
assertType('bool|mysqli_result', $result);

$result = $mysqli->query('SELECT email, adaid FROM ada WHERE adaid='.$mysqli->real_escape_string($nonE));
assertType('bool|mysqli_result', $result);
}
}
27 changes: 27 additions & 0 deletions tests/data/pdo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,4 +172,31 @@ public function quote(PDO $pdo, int $i, float $f, $n, string $s, $nonE, string $
assertType('non-empty-string|false', $pdo->quote($nonE, PDO::PARAM_LOB));
assertType('string|false', $pdo->quote($s, PDO::PARAM_LOB));
}

/**
* @param numeric $n
* @param non-empty-string $nonE
* @param numeric-string $numericString
*/
public function quotedArguments(PDO $pdo, int $i, float $f, $n, string $s, $nonE, string $numericString)
{
$stmt = $pdo->query('SELECT email, adaid FROM ada WHERE adaid='.$pdo->quote((string) $i), PDO::FETCH_ASSOC);
assertType('PDOStatement<array{email: string, adaid: int<0, 4294967295>}>', $stmt);

$stmt = $pdo->query('SELECT email, adaid FROM ada WHERE adaid='.$pdo->quote((string) $f), PDO::FETCH_ASSOC);
assertType('PDOStatement<array{email: string, adaid: int<0, 4294967295>}>', $stmt);

$stmt = $pdo->query('SELECT email, adaid FROM ada WHERE adaid='.$pdo->quote((string) $n), PDO::FETCH_ASSOC);
assertType('PDOStatement<array{email: string, adaid: int<0, 4294967295>}>', $stmt);

$stmt = $pdo->query('SELECT email, adaid FROM ada WHERE adaid='.$pdo->quote($numericString), PDO::FETCH_ASSOC);
assertType('PDOStatement<array{email: string, adaid: int<0, 4294967295>}>', $stmt);

// when quote() cannot return a numeric-string, we can't infer the precise result-type
$stmt = $pdo->query('SELECT email, adaid FROM ada WHERE adaid='.$pdo->quote($s), PDO::FETCH_ASSOC);
assertType('PDOStatement<array>|false', $stmt);

$stmt = $pdo->query('SELECT email, adaid FROM ada WHERE adaid='.$pdo->quote($nonE), PDO::FETCH_ASSOC);
assertType('PDOStatement<array>|false', $stmt);
}
}