Skip to content

Conversation

@staabm
Copy link
Owner

@staabm staabm commented Feb 20, 2022

closes #286

@staabm staabm changed the title implement ReplayAndRecordingQueryReflector implement ReplayAndRecordingQueryReflector Feb 20, 2022
@staabm
Copy link
Owner Author

staabm commented Feb 20, 2022

todo:

  • document differences between different reflectors
  • tests?

$this->reflectionCache = $reflectionCache;
}

private function getRecordingReflector(): ?RecordingQueryReflector
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe utilize LazyQueryReflector instead?

@staabm staabm marked this pull request as ready for review February 20, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RecordAndReplayReflector

3 participants