Added support for JSON datatype

[marmichalski]

Expect this to fail (in more places than intended).

The significant failing job is: PHPUnit (8.0, mysql:8.0, pdo, recording), the rest is failing because of cache mismatch (I believe?).

Closes: #357

[marmichalski]

According to pdo_mysql src, native_type can be missing from the return value:
https://github.com/php/php-src/blob/14319c203cb13a7cc0644fb4276d6e62338fda5e/ext/pdo_mysql/mysql_statement.c#L806-L808

and in that case, we may fallback to the pdo_type, problem is, according to my understanding of the sources, this can be either INT or STR... https://github.com/php/php-src/blob/14319c203cb13a7cc0644fb4276d6e62338fda5e/ext/pdo_mysql/mysql_statement.c#L811-L827.

[marmichalski]

I have not updated the ColumnMeta to represent the actual state of PDO.getColumnMeta return value as just ignoring this line was so much easier... 🤡

[staabm]

This looks great, thank you.

Can the same bug be reproduced with PGSQL?

Additionally it would be cool if you could add a new testcase for the DbaInferenceTest which contains sql queries using the JSON column, to make sure it also works in non trivial SELECT * FROM x cases

[marmichalski]

Can the same bug be reproduced with PGSQL?

Kind of. PdoPgQueryReflector does not crash in case of json, because the extension fallbacks to selecting TYPNAM from PG_TYPE and the way phpstan-dba works will make it just return MixedType. This has been updated to map json & jsonb types into StringType & bool (boolean) to BooleanType.

This still possibly may not return native_type, but I am unaware of when this could happen, therefore leaving this until reproducible crash scenario is found, which will make it easier to fix 😎

Additionally it would be cool if you could add a new testcase for the DbaInferenceTest which contains sql queries using the JSON column, to make sure it also works in non trivial SELECT * FROM x cases

Yes, I could, but do you have something specific in mind? As SELECT c_json FROM ... is probably just the same thing as the SELECT * ...? 🤔

[staabm]

Kind of. PdoPgQueryReflector does not crash in case of json, because the extension fallbacks to selecting TYPNAM from PG_TYPE and the way phpstan-dba works will make it just return MixedType. This has been updated to map json & jsonb types into StringType & bool (boolean) to BooleanType.

cool

This still possibly may not return native_type, but I am unaware of when this could happen, therefore leaving this until reproducible crash scenario is found, which will make it easier to fix 😎

makes sense, perfect.

Yes, I could, but do you have something specific in mind? As SELECT c_json FROM ... is probably just the same thing as the SELECT * ...? 🤔

I am thinking about very simple json sql select queries which involve the json columns with e.g. WHERE conditions working on the json column with e.g. json functions.

a few real world statements so we can be sure phpstan-dba does not detect syntax errors etc

please put them into a new file under https://github.com/staabm/phpstan-dba/tree/main/tests/default/data

[staabm]

as this is really useful as is, I will merge for now.

would be great you could add the JSON tests we talked about in a separate PR.

Thank you.

[marmichalski]

would be great you could add the JSON tests we talked about in a separate PR

Sure, I should be able to deliver over the weekend 🙃