[MySQL] Treat decimal as numeric-string

[marmichalski]

Closes #428.

[marmichalski]

(this is probably redundant)

[marmichalski]

Tested and result of AVG is also a string.

[staabm]

Looks great thx. Did you verify the results on mysqli and pdo+mysql?

[staabm]

See line 161 how a numeric string is built. An accessory type cannot stand on its own in the phpstan type system

[marmichalski]

Yea, I've seen it, but instantiated it just like this and it seems to work ? 🙈

[staabm]

It works for the tests but will not work in the bigger picture when the type needs to be combined with other logic within phpstan

[marmichalski]

Looks great thx. Did you verify the results on mysqli and pdo+mysql?

I have tested only with pdo. I can do some more testing before we merge this

[marmichalski]

Looks great thx. Did you verify the results on mysqli and pdo+mysql?

I have tested only with pdo. I can do some more testing before we merge this

best code

// pdo5 -> pdo + mysql:5.7, pdo8 -> pdo + mysql:8.0; mysqli is mysqli
var_dump(
    $pdo5->query('SELECT eadavk FROM ak')->fetch(\PDO::FETCH_ASSOC),
    $pdo8->query('SELECT eadavk FROM ak')->fetch(\PDO::FETCH_ASSOC),

    $mysqli5->query('SELECT eadavk FROM ak')->fetch_row(),
    $mysqli8->query('SELECT eadavk FROM ak')->fetch_row(),
);

array(1) {
  ["eadavk"]=>
  string(6) "154.23"
}
array(1) {
  ["eadavk"]=>
  string(6) "154.23"
}
array(1) {
  [0]=>
  string(6) "154.23"
}
array(1) {
  [0]=>
  string(6) "154.23"
}

[staabm]

Awesome thx, just pushed a new bugfix release