-
-
Notifications
You must be signed in to change notification settings - Fork 23
Add support for StaticCall
#766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
without a test we cannot merge the PR. how do the problems locally manifest? |
|
For some reason running composer test tries to install some packages, including adding sqlftw/sqlftw to composer, and then just quits because it can't find |
|
you need to copy |
|
EDIT: Okay I had to manually import schema.sql... would be nice if this happened automatically, or at least was documented in a contributing guide or something. |
added some rough description in a5cee18 |
|
So there's skipped tests that use |
|
Well I tried changing it to fully qualified name, and now it doesn't seem to actually match them. Is the rules code not actually checking for these correctly because all tests don't use fully qualified classes? |
|
let me have a look |
|
composer.json changes every time I run composer test by the way. |
yeah.. thats a sideffect of running the tests. its not expected to be committed. |
|
thank you. released in 0.4.2 |
Fixes #765
I am unable to get tests working locally, so I can't really add one.