✨ Check existing email for register

Author: AnandChowdhary

src/crud/email.ts

@@ -188,6 +188,20 @@ export const getEmailObject = async (email: string) => {
   );
 };
 
+/**
+ * Get the detailed email object from a verified email
+ */
+export const getVerifiedEmailObject = async (email: string) => {
+  return (<Email[]>(
+    await cachedQuery(
+      CacheCategories.EMAIL,
+      email,
+      "SELECT * FROM emails WHERE email = ? AND isVerified = 1 LIMIT 1",
+      [email]
+    )
+  ))[0];
+};
+
 /**
  * Get a list of all verified emails of a user
  */
@@ -208,3 +222,15 @@ export const getUserVerifiedEmails = async (user: User | number) => {
     )
   ));
 };
+
+export const checkIfNewEmail = async (email: string) => {
+  email = normalizeEmail(email) || email;
+  let hasEmail = true;
+  try {
+    (await getVerifiedEmailObject(email)).id;
+  } catch (error) {
+    hasEmail = false;
+  }
+  if (hasEmail) throw new Error(ErrorCode.EMAIL_EXISTS);
+  return;
+};

src/interfaces/enum.ts

@@ -46,6 +46,7 @@ export enum ErrorCode {
   MISSING_PRIMARY_EMAIL = "422/missing-primary-email",
   MISSING_PASSWORD = "422/missing-password",
   MISSING_FIELD = "422/missing-field",
+  EMAIL_EXISTS = "422/email-exists",
   USER_NOT_FOUND = "404/user-not-found",
   INVALID_LOGIN = "401/invalid-login",
   INSUFFICIENT_PERMISSION = "401/insufficient-permission",

src/rest/auth.ts

@@ -7,7 +7,12 @@ import {
   addApprovedLocation
 } from "../crud/user";
 import { InsertResult } from "../interfaces/mysql";
-import { createEmail, updateEmail, getEmail } from "../crud/email";
+import {
+  createEmail,
+  updateEmail,
+  getEmail,
+  checkIfNewEmail
+} from "../crud/email";
 import { mail } from "../helpers/mail";
 import {
   verifyToken,
@@ -69,6 +74,7 @@ export const register = async (
   organizationId?: number,
   role?: MembershipRole
 ) => {
+  if (email) await checkIfNewEmail(email);
   // Create user
   const result = <InsertResult>await createUser(user);
   const userId = result.insertId;

src/rest/email.ts

@@ -5,10 +5,16 @@ import {
   getUserVerifiedEmails,
   getUserPrimaryEmailObject,
   deleteEmail,
-  getUserEmails
+  getUserEmails,
+  checkIfNewEmail
 } from "../crud/email";
 import { createEvent } from "../crud/event";
-import { ErrorCode, EventType, Authorizations, ValidationTypes } from "../interfaces/enum";
+import {
+  ErrorCode,
+  EventType,
+  Authorizations,
+  ValidationTypes
+} from "../interfaces/enum";
 import { updateUser } from "../crud/user";
 import { can } from "../helpers/authorization";
 import { validate } from "../helpers/utils";
@@ -28,6 +34,7 @@ export const addEmailToUser = async (
   locals: Locals
 ) => {
   validate(email, ValidationTypes.EMAIL);
+  await checkIfNewEmail(email);
   await createEmail({ email, userId });
   await createEvent(
     { userId, type: EventType.EMAIL_CREATED, data: { email } },