Skip to content

Conversation

@philvarner
Copy link
Collaborator

@philvarner philvarner commented May 26, 2022

Related Issue(s): #172

Description:

  • replace existing static analysis and lint tooling (e.g., yapf) with the standard python stac tooling from pystac and stactools (e.g., black, mypy, etc)

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@philvarner philvarner changed the title Pv/tooling sync static analysis tooling with pystac and stactools May 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #183 (c49cd02) into main (0519077) will decrease coverage by 0.02%.
The diff coverage is 82.95%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   82.60%   82.57%   -0.03%     
==========================================
  Files           9        9              
  Lines         592      597       +5     
==========================================
+ Hits          489      493       +4     
- Misses        103      104       +1     
Impacted Files Coverage Δ
pystac_client/cli.py 61.86% <72.05%> (+0.12%) ⬆️
pystac_client/stac_api_io.py 82.24% <80.76%> (ø)
pystac_client/item_search.py 90.77% <88.23%> (+0.03%) ⬆️
pystac_client/__init__.py 100.00% <100.00%> (ø)
pystac_client/client.py 80.00% <100.00%> (ø)
pystac_client/collection_client.py 86.66% <100.00%> (+0.95%) ⬆️
pystac_client/conformance.py 100.00% <100.00%> (ø)
pystac_client/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0519077...c49cd02. Read the comment docs.

@philvarner
Copy link
Collaborator Author

@gadomski @matthewhanson this is ready for review now

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor script change requested. I did my best to look through the .py diffs, but I'll be honest I didn't scan them all -- I assume that there were no functional changes, that the diff noise was from applying the formatters.

@philvarner philvarner requested a review from gadomski May 31, 2022 14:50
@philvarner philvarner merged commit 2324110 into main May 31, 2022
@philvarner philvarner deleted the pv/tooling branch May 31, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants