Skip to content

Conversation

@philvarner
Copy link
Collaborator

Related Issue(s): #171

Description:

  • fix fields typing
  • fix fields behavior for GET and POST

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #184 (814fcc4) into main (2324110) will increase coverage by 1.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   82.57%   83.87%   +1.29%     
==========================================
  Files           9        9              
  Lines         597      620      +23     
==========================================
+ Hits          493      520      +27     
+ Misses        104      100       -4     
Impacted Files Coverage Δ
pystac_client/item_search.py 92.85% <100.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2324110...814fcc4. Read the comment docs.

@philvarner philvarner requested a review from gadomski May 31, 2022 16:35
@philvarner philvarner merged commit a274bb6 into main May 31, 2022
@philvarner philvarner deleted the pv/fix-fields-typing-and-post-format branch June 8, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants