Skip to content

Conversation

@philvarner
Copy link
Collaborator

@philvarner philvarner commented Jun 3, 2022

Related Issue(s):

Description:

  • Incorrect conformance class was being checked for Collections
  • most Item Search extensions were not being checked.
  • fix typing definitions so modified code type checks correctly

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #223 (2bfd60b) into main (6a1295e) will increase coverage by 0.06%.
The diff coverage is 91.89%.

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   83.47%   83.54%   +0.06%     
==========================================
  Files          10       10              
  Lines         702      711       +9     
==========================================
+ Hits          586      594       +8     
- Misses        116      117       +1     
Impacted Files Coverage Δ
pystac_client/client.py 82.05% <75.00%> (+0.10%) ⬆️
pystac_client/collection_client.py 76.74% <100.00%> (ø)
pystac_client/conformance.py 100.00% <100.00%> (ø)
pystac_client/item_search.py 91.92% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1295e...2bfd60b. Read the comment docs.

@philvarner philvarner changed the title Pv/fix conformance class checking fix conformance class checking Jun 3, 2022
@philvarner philvarner marked this pull request as ready for review June 6, 2022 17:34
@philvarner philvarner merged commit 49de56d into main Jun 6, 2022
@philvarner philvarner deleted the pv/fix-conformance-class-checking branch June 6, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants