Skip to content

Conversation

@philvarner
Copy link
Collaborator

@philvarner philvarner commented Jun 6, 2022

Related Issue(s):

Description:

  • All of the methods that we advertise as Iterators, when they should be typed as Generators because of their use of yield

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #226 (8abcd7f) into main (49de56d) will decrease coverage by 0.18%.
The diff coverage is 86.44%.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   83.61%   83.42%   -0.19%     
==========================================
  Files          10       10              
  Lines         708      712       +4     
==========================================
+ Hits          592      594       +2     
- Misses        116      118       +2     
Impacted Files Coverage Δ
pystac_client/stac_api_io.py 84.54% <83.33%> (ø)
pystac_client/client.py 81.25% <85.18%> (-1.65%) ⬇️
pystac_client/item_search.py 91.90% <86.95%> (ø)
pystac_client/collection_client.py 76.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49de56d...8abcd7f. Read the comment docs.

@philvarner philvarner changed the title Pv/generators not iterators change type annotations using Iterator to use the more accurate Generator type Jun 6, 2022
@philvarner philvarner marked this pull request as ready for review June 7, 2022 14:11
@philvarner philvarner requested a review from gadomski June 7, 2022 17:02
@philvarner philvarner changed the title change type annotations using Iterator to use the more accurate Generator type use Iterator instead of Iterable consistently for type hints Jun 7, 2022
@philvarner philvarner merged commit 9890615 into main Jun 7, 2022
@philvarner philvarner deleted the pv/generators-not-iterators branch June 7, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants