Skip to content

Conversation

@philvarner
Copy link
Collaborator

@philvarner philvarner commented Jun 6, 2022

Related Issue(s): #189

Description:

  • fix typing issues in ItemSearch

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@philvarner philvarner changed the title Pv/fix item search types fix item search types Jun 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #228 (eb73de0) into main (43b4325) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files          10       10           
  Lines         712      712           
=======================================
  Hits          594      594           
  Misses        118      118           
Impacted Files Coverage Δ
pystac_client/item_search.py 91.90% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b4325...eb73de0. Read the comment docs.

@philvarner philvarner marked this pull request as ready for review June 7, 2022 19:41
@philvarner philvarner merged commit ed30967 into main Jun 8, 2022
@philvarner philvarner deleted the pv/fix-item-search-types branch June 8, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants