Skip to content

Conversation

@gadomski
Copy link
Member

Description:

This lets remove a bunch of # type: ignores. Normally I'd sidecar this change into a more meaningful PR, but since it touches so many lines, I made it it's own PR to make reviewing easier.

PR Checklist:

  • Code is formatted
  • Tests pass

This lets remove a bunch of # type: ignores
@gadomski gadomski added this to the 0.5.2 milestone Jan 19, 2023
@gadomski gadomski requested a review from pjhartzell January 19, 2023 13:20
@gadomski gadomski self-assigned this Jan 19, 2023
@pjhartzell
Copy link
Collaborator

pjhartzell commented Jan 19, 2023

@gadomski What do you mean by "autoupdate"?

@gadomski
Copy link
Member Author

I ran pre-commit autoupdate to get these version bumps in the .pre-commit-config.yaml file.

@pjhartzell
Copy link
Collaborator

Nice. Didn't know that. How convenient. 🙂

@gadomski gadomski enabled auto-merge (rebase) January 19, 2023 15:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 85.05% // Head: 85.05% // No change to project coverage 👍

Coverage data is based on head (bd17a73) compared to base (381d256).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files          11       11           
  Lines         823      823           
=======================================
  Hits          700      700           
  Misses        123      123           
Impacted Files Coverage Δ
pystac_client/stac_api_io.py 86.84% <ø> (ø)
pystac_client/collection_client.py 81.96% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski merged commit 00e4c98 into main Jan 19, 2023
@gadomski gadomski deleted the autoupdate-pre-commit branch January 26, 2023 18:46
@gadomski gadomski modified the milestones: 0.5.2, 0.6.0 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants