Fix fail when header has more than one equals #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ircwaves
changed the title
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 86.24% 87.12% +0.87%
==========================================
Files 11 11
Lines 829 831 +2
==========================================
+ Hits 715 724 +9
+ Misses 114 107 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gadomski
requested changes
Mar 3, 2023
ircwaves
force-pushed
the
fix-fail-when-auth-has-equals
branch
from
ad3c205 to
a14cf68
Compare
ircwaves
commented
Mar 3, 2023
gadomski
approved these changes
Mar 3, 2023
gadomski
force-pushed
the
fix-fail-when-auth-has-equals
branch
2 times, most recently
from
77e2189 to
9a42673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Adding a header from the CLI failed to parse if there was more than one equal sign (
=). This fixes that, and adds a test which demonstrates the improvement.PR Checklist: