Skip to content

Conversation

@jsignell
Copy link
Member

Related Issue(s):

Description:

Switch CI to use conda env in same as on read-the-docs, add missing conda-only dependencies to env, flip nbsphinx_allow_errors to False.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@jsignell jsignell requested a review from gadomski April 24, 2023 16:49
@jsignell jsignell self-assigned this Apr 24, 2023
@jsignell jsignell linked an issue Apr 24, 2023 that may be closed by this pull request
@gadomski gadomski added the documentation Improvements or additions to documentation label Apr 24, 2023
@gadomski gadomski modified the milestones: 0.6.2, 0.7.0 Apr 24, 2023
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI file isn't quite correct:

image

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14 ⚠️

Comparison is base (0a43803) 87.51% compared to head (edf8dc0) 87.38%.

❗ Current head edf8dc0 differs from pull request most recent head 466d43e. Consider uploading reports for the commit 466d43e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   87.51%   87.38%   -0.14%     
==========================================
  Files          12       12              
  Lines         857      864       +7     
==========================================
+ Hits          750      755       +5     
- Misses        107      109       +2     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsignell
Copy link
Member Author

I think I fixed the issue with the original workflow config, but now the pip section of the environment isn't resolving. There seem to be similar things going on with the other CI jobs that were untouched, so maybe this is coming from somewhere else....

@jsignell
Copy link
Member Author

Ok! I made it out the other side on debugging the github action 😅

@jsignell jsignell requested a review from gadomski April 25, 2023 14:35
@gadomski gadomski enabled auto-merge (squash) April 25, 2023 14:36
@gadomski gadomski merged commit c421ef9 into stac-utils:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run tutorial notebooks in CI

3 participants