Skip to content

Conversation

@gadomski
Copy link
Member

@gadomski gadomski commented May 3, 2023

Description:
These didn't get caught by CI because they were in the environment.yml file. Doesn't need a CHANGELOG entry.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski added the documentation Improvements or additions to documentation label May 3, 2023
@gadomski gadomski requested a review from jsignell May 3, 2023 15:25
@gadomski gadomski self-assigned this May 3, 2023
@gadomski gadomski force-pushed the update-doc-dependencies branch 2 times, most recently from 7fb4ec3 to f1e67cd Compare May 3, 2023 18:42
These didn't get caught by CI because they were in the environment.yml file.
@gadomski gadomski force-pushed the update-doc-dependencies branch from f1e67cd to fba2f7d Compare May 3, 2023 18:45
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a6f02c) 87.38% compared to head (fba2f7d) 87.38%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          12       12           
  Lines         864      864           
=======================================
  Hits          755      755           
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!

@gadomski gadomski merged commit 1e3be8a into main May 4, 2023
@gadomski gadomski deleted the update-doc-dependencies branch May 4, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants