Skip to content

Conversation

@jsignell
Copy link
Member

To get #1580 into production

Basically all the cassettes will now be touched on every release because of the version number being part of the "User-Agent" header.

@jsignell jsignell requested a review from gadomski September 18, 2025 14:59
@gadomski
Copy link
Member

Basically all the cassettes will now be touched on every release because of the version number being part of the "User-Agent" header.

Should we consider https://pypi.org/project/responses/ or something similar instead? I've started using https://lundberg.github.io/respx/ for my httpx-based projects and am liking it more than a VCR-based approach.

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (0e13b6a) to head (867c15f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1581   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          55       55           
  Lines        8375     8375           
  Branches      965      965           
=======================================
  Hits         7737     7737           
  Misses        453      453           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsignell
Copy link
Member Author

Basically all the cassettes will now be touched on every release because of the version number being part of the "User-Agent" header.

Should we consider https://pypi.org/project/responses/ or something similar instead? I've started using https://lundberg.github.io/respx/ for my httpx-based projects and am liking it more than a VCR-based approach.

I basically hate cassettes but I hate thinking about them even more so +1 from me if you have an idea of how to make things better

@jsignell jsignell added this pull request to the merge queue Sep 18, 2025
Merged via the queue into main with commit a5e0408 Sep 18, 2025
19 checks passed
@jsignell jsignell deleted the release/v1.14.1 branch September 18, 2025 15:07
kmodali pushed a commit to kmodali/pystac that referenced this pull request Oct 16, 2025
* Update version

* Update cassettes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants