Suspicious TypedDict typing

[Zaczero]

stac-fastapi/stac_fastapi/types/stac_fastapi/types/stac.py

Line 55 in 20ae9cf

class Item(TypedDict, total=False):

it says total=False, but it also uses Optional[...], something's not right.

[vincentsarago]

@Zaczero thanks for the issue. Can I ask next time that you extend your thought a bit 🙏

I think we could use typing.NotRequired https://peps.python.org/pep-0655/ here instead of Optional

Feel free to start a PR 🙏

[Zaczero]

Hi! I confused Optional with NotRequired. What I originally meant, and what motivated me to report this issue, is that these type hints (total=False) make everything not required, so when using them I always need to check for existence. But from my limited STAC knowledge, fields like id/collection/etc. are always present, otherwise these wouldn't be proper STAC items. So I found this total=False usage, without Required[...], suspicious here.