Skip to content

Conversation

@seanyen
Copy link
Contributor

@seanyen seanyen commented Nov 13, 2019

This is a pull request to port a patch from eigenpy-feedstock. In conda configuration, the Python modules and the native library doesn't share the same install prefix. Hope we can add some flexibility to customize where to place Python modules in CMake files.

@seanyen
Copy link
Contributor Author

seanyen commented Nov 13, 2019

There was a travis-ci build timeout so I trigger another round.

@jcarpent
Copy link
Contributor

OK. You can also do a git commit --amend to avoid a new commit ;)

@jcarpent
Copy link
Contributor

@seanyen Do you need a new release now?

@nim65s
Copy link
Contributor

nim65s commented Nov 13, 2019

There is also a "Restart build" button, but I guess it is not accessible by everyone.

@seanyen
Copy link
Contributor Author

seanyen commented Nov 13, 2019

@jcarpent if you have bandwidth for a new release, that would be fantastic. I really appreciated your time. :)

I didn't know the git commit --amend trick. Every day I learned something new.

@jcarpent jcarpent merged commit 1d2da9d into stack-of-tasks:devel Nov 13, 2019
@jcarpent
Copy link
Contributor

@seanyen Can you handle the conda forge?

@gabrielebndn
Copy link
Contributor

The easiest way to trigger a new CI is to close the PR and reopen it

@seanyen
Copy link
Contributor Author

seanyen commented Nov 13, 2019

@seanyen Can you handle the conda forge?

Sure, I am on it now.

@wxmerkt
Copy link
Member

wxmerkt commented Nov 13, 2019

There is also a "Restart build" button, but I guess it is not accessible by everyone.

It is accessible as soon as you login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants