feat: init product command for patchable #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dervoeti
force-pushed
the
feat/patchable-init-product-command
branch
from
2c17e7e to
618159c
Compare
nightkr
reviewed
May 14, 2025
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
nightkr
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to make product initialization possible via CLI, since everything else can be done by invoking some
patchablesubcommand as well. Not a huge problem, but it feels a bit awkward to write TOML by hand for that step.This is an idea on how to realize that: I added two subcommands to
patchable init, one for products and one for versions (patchable init product/patchable init version).The diff looks worse than it really is, the
Initpart was moved into theInitType::Versionsubcommand and a newInitType::Productwas added.