Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Oct 30, 2025

Closes stackabletech/issues#789

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@NickLarsenNZ NickLarsenNZ moved this to Development: In Progress in Stackable Engineering Oct 30, 2025
boil-config.toml once renovate can check there (for consistency)
Otherwise cargo can't be found

```
error: the 'cargo' binary, normally provided by the 'cargo' component, is not applicable to the '1.89.0-x86_64-unknown-linux-gnu' toolchain
```
NOTE: The ubi9-rust-builder could not be used as it contains `ONBUILD`
steps which we need to run after patchable does it's thing. Also it is
specifically designed for operators and their layout (under `rust/` and
using workspaces).
NOTE: I removed async/await parts from the original patch as that comes after 0.49.0

```sh
pushd $(cargo patchable checkout vector 0.49.0)

git remote add lfrancke https://github.com/lfrancke/vector

git fetch lfrancke

git cherry-pick 3ce729073f23631dd7b5525be640b5fa15af0223
and git cherry-pick --continue
git commit --amend

popd
cargo patchable export vector 0.49.0
```
This seems to be added to other images, so I'm just copying that.
@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Oct 30, 2025
@NickLarsenNZ NickLarsenNZ self-assigned this Oct 30, 2025
@NickLarsenNZ
Copy link
Member Author

Tested with zookeeper: stackabletech/issues#789 (comment)

@Techassi Techassi self-requested a review October 30, 2025 14:03
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, just a few minor comments and questions.

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Oct 30, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 30, 2025
Merged via the queue into main with commit ccd61f4 Oct 30, 2025
3 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/vector-patch branch October 30, 2025 15:35
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

Apply the **Vector** fix to the Vector image layer.

3 participants