Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Nov 5, 2025

Description

Fixes stackabletech/issues#782

Build and patch reload4j to address XMLLayout racing problems.

reload4j sources and jars are in the built Kafka images:

❯ docker run --rm -ti oci.stackable.tech/sdp/kafka:3.9.1-stackable0.0.0-dev find /stackable -name 'reload*'
/stackable/kafka_2.13-3.9.1-stackable0.0.0-dev/libs/reload4j-1.2.25.jar
/stackable/reload4j-1.2.25-src.tar.gz

Logging tests pass:

--- PASS: kuttl (22.72s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/logging_kafka-3.9.1_zookeeper-latest-3.9.4_openshift-false (22.42s)
PASS

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@razvan razvan requested a review from a team November 5, 2025 13:04
@razvan razvan requested a review from lfrancke November 5, 2025 13:48
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not build the image just looked at the code

@razvan razvan added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit b594ca8 Nov 5, 2025
3 checks passed
@razvan razvan deleted the fix/kafka-reload4j branch November 5, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply logback fix to Kafka 3.7.2 and 3.9.1 (if needed)

4 participants