Skip to content

Attempt to improve random connection errors in CI #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Attempt to improve random connection errors in CI #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4acd93
Attempt to improve random connection errors in CI
lfrancke Sep 17, 2024
3e2807f
Merge branch 'main' into feat/maven-improvements
lfrancke Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions java-devel/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ RUN microdnf update && \

ENV JAVA_HOME=/usr/lib/jvm/jre-${PRODUCT}

COPY --chown=stackable:0 java-devel/stackable/settings.xml /stackable/.m2/settings.xml

# Mitigation for CVE-2021-44228 (Log4Shell)
# This variable is supported as of Log4j version 2.10 and
# disables the vulnerable feature
Expand Down
29 changes: 29 additions & 0 deletions java-devel/stackable/settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<settings>
<profiles>
<profile>
<id>stackable</id>
<properties>
<!--
This is to work around an issue where Maven builds in Github Actions would randomly fail.
There is some evidence that points at Azure networking as the root cause where it closes idle connections (silently) after 4 minutes.
Maven would then sometimes reuse an "old" connection from its connection pool and would encounter issues due to these connection closures.
This patch changes the TTL for the connections to a lower value than 4 minutes (240s), the default is 300s (5min).

There are two properties here because sometimes in November 2023 the name was changed.
The new name will only take effect as of Maven 4, but it doesn't hurt to add it here already, therefore, we just add both properties here.
https://issues.apache.org/jira/browse/MRESOLVER-440
-->

<!-- Old name: maven-resolver 1.x, Maven 3.x -->
<aether.connector.http.connectionMaxTtl>30</aether.connector.http.connectionMaxTtl>

<!-- New name: maven-resolver 2.x, as of Maven 4.x -->
<aether.transport.http.connectionMaxTtl>30</aether.transport.http.connectionMaxTtl>
</properties>
</profile>
</profiles>
<activeProfiles>
<!--make the stackable profile active all the time -->
<activeProfile>stackable</activeProfile>
</activeProfiles>
</settings>