-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Bump stackable-operator to get updated s3 region structs #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
}; | ||
|
||
if let Some(s3) = s3_conn { | ||
conf.insert(S3_REGION_NAME.to_string(), Some(s3.region.name.to_string())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think according to https://druid.apache.org/docs/latest/development/extensions-core/s3/#aws-region aws.region
needs to go into the JVM args, not the Druid config.
Via env var AWS_REGION
sounds even easier to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, but that also seems strange to be since you might want to connect to buckets in multiple regions.
The S3 extension needs testing with AWS S3 buckets:
- Deep storage
- S3 Ingestion
I'm just trying to get a working baseline.
This won't be done because:
|
Description
Part of stackabletech/issues#696.
Caution
Blocked on testing. Need to test how the global region setting works for buckets in different regions.
Per s3 extension docs:
Note
I did not add it to jvm.config, as it will be specific to the bucket being accessed.
Definition of Done Checklist