Skip to content

chore(tests): update omid version #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2024
Merged

chore(tests): update omid version #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30124ec
chore(tests): update omid version
razvan Sep 11, 2024
5740c1e
fix(test): omid default port and test timeout
razvan Sep 11, 2024
5c702fd
update changelog
razvan Sep 11, 2024
2da2270
update hbase latest
razvan Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
### Fixed

- Implement `envOverrides` for HbaseCluster ([#550]).
- Omid test: use 1.1.2, update default port number and raise test timeout ([#556]).

[#548]: https://github.com/stackabletech/hbase-operator/pull/548
[#550]: https://github.com/stackabletech/hbase-operator/pull/550
[#556]: https://github.com/stackabletech/hbase-operator/pull/556

## [24.7.0] - 2024-07-24

Expand Down
2 changes: 1 addition & 1 deletion tests/templates/kuttl/omid/40-assert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
apiVersion: kuttl.dev/v1beta1
kind: TestAssert
timeout: 240
timeout: 300
---
apiVersion: apps/v1
kind: StatefulSet
Expand Down
6 changes: 3 additions & 3 deletions tests/templates/kuttl/omid/40-install-omid.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
# principal: omid_hbase_client
# keytab: /path/to/hbase/client/keytab
omidClientConfiguration: !!org.apache.omid.tso.client.OmidClientConfiguration
connectionString: "localhost:54758"
connectionString: "localhost:24758"
log4j2.properties: |
status = warn
dest = err
Expand Down Expand Up @@ -83,12 +83,12 @@ spec:
value: "-Xmx3g -Xms3g"
ports:
# See also hbase-omid-client-config.yml above where the client is configured with this port
- containerPort: 54758
- containerPort: 24758
name: tso
protocol: TCP
readinessProbe:
# The tso server takes a while to start up, so we need to be patient.
failureThreshold: 3
failureThreshold: 12
Comment on lines 90 to +91
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably use a Startup Probe here so that the readinessProbe only has to consider failures after start?

(Just an idea for the future).

periodSeconds: 10
successThreshold: 1
tcpSocket:
Expand Down
4 changes: 2 additions & 2 deletions tests/test-definition.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dimensions:
# - 2.6.0,docker.stackable.tech/sandbox/hbase:2.6.0-stackable0.0.0-dev
- name: hbase-latest
values:
- 2.4.18
- 2.6.0
# - 2.4.18,docker.stackable.tech/sandbox/hbase:2.4.18-stackable0.0.0-dev
- name: hdfs
values:
Expand Down Expand Up @@ -52,7 +52,7 @@ dimensions:
- "false"
- name: omid
values:
- 1.1.0
- 1.1.2
# To use a custom image, add a comma and the full name after the product version
# - 1.1.0,docker.stackable.tech/sandbox/omid:1.1.0-stackable0.0.0-dev
tests:
Expand Down
Loading